kosiew opened a new pull request, #25773:
URL: https://github.com/apache/datafusion/pull/25773

   ## Which issue does this PR close?
   
   - Part of #25031
   
   ## Rationale for this change
   
   The extended Q6 benchmark uses different SQL from the other ClickBench 
runners, while Q15 and Q16 are absent from the SQL-benchmark suite and SQL 
logic test. These copies can drift again when a query is edited in only one 
place.
   
   ## What changes are included in this PR?
   
   - Remove the URL cast from the extended Q6 benchmark query.
   - Add extended Q15 and Q16 SQL benchmarks and corresponding SQL logic test 
entries.
   - Add a parity test for standard and extended ClickBench. It checks that 
each benchmark query appears in its SQL logic test and that benchmark and 
legacy query files have matching IDs and normalized SQL.
   - Update both SQL logic test headers to identify the mirrored query 
locations.
   
   ## Are these changes tested?
   
   The patch adds `clickbench_parity.rs` and six unit tests covering SQL logic 
test parsing and SQL normalization. It also adds Q15/Q16 SQL logic test entries 
with expected value `0`.
   
   The diff does not show test execution, generation of those expected values, 
or the requested Q6 comparisons in single and partitioned configurations.
   
   ## Are there any user-facing changes?
   
   The extended Q6 SQL benchmark now runs without the URL cast. Q15 and Q16 are 
added to the extended SQL-benchmark suite. The diff does not establish whether 
removing the cast changes Q6 results. No public API change is shown.
   
   ## LLM-generated code disclosure
   
   This PR includes LLM-generated code and comments. All LLM-generated content 
has been manually reviewed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to