andygrove opened a new pull request, #6267: URL: https://github.com/apache/datafusion-comet/pull/6267
## Which issue does this PR close? No issue filed for this. It is a missed step from the release checklist rather than a bug or enhancement. ## Rationale for this change The release checklist says to protect each new release branch in `.asf.yaml`, so that released code can only change through a reviewed pull request. That step was missed for the two newest release branches. `protected_branches` stops at `branch-0.17`, and GitHub reports both newer branches as unprotected: ``` $ gh api repos/apache/datafusion-comet/branches/branch-0.17 -q .protected true $ gh api repos/apache/datafusion-comet/branches/branch-1.0 -q .protected false $ gh api repos/apache/datafusion-comet/branches/branch-1.1 -q .protected false ``` `branch-1.1` is the branch for the upcoming 1.1.0 release, so it matters most there. ## What changes are included in this PR? Adds `branch-1.0` and `branch-1.1` to `protected_branches` in `.asf.yaml`, with the same rule as every other release branch: one approving review. ASF applies `.asf.yaml` from the default branch, so this targets `main`. The merge queue ruleset still covers only the default branch, and `main`'s required status check is unchanged. ## How are these changes tested? - The edited file parses, and `protected_branches` now lists `main`, `branch-0.1` through `branch-0.17`, `branch-1.0` and `branch-1.1`. - Every `branch-*` ref on `apache/datafusion-comet` now has an entry. - `python3 dev/ci/check-ci-config.py` passes. It reads the `main` entry under `protected_branches` for the required status check, which this change leaves alone. - Once this merges and ASF applies it, `gh api repos/apache/datafusion-comet/branches/branch-1.1 -q .protected` should report `true`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
