andygrove commented on code in PR #6135:
URL: https://github.com/apache/datafusion-comet/pull/6135#discussion_r4083355095
##########
spark/src/main/scala/org/apache/comet/expressions/CometCast.scala:
##########
@@ -155,10 +155,6 @@ object CometCast
castBuilder.setChild(childExpr)
castBuilder.setDatatype(dataType)
castBuilder.setEvalMode(evalModeToProto(evalMode))
- castBuilder.setAllowIncompat(
- SQLConf.get
-
.getConfString(CometConf.getExprAllowIncompatConfigKey(classOf[Cast]), "false")
- .toBoolean)
Review Comment:
This removes the last use of `CometConf` in this file, so `import
org.apache.comet.CometConf` at the top is now unused. The `lint-java` jobs run
scalafix's `RemoveUnused` rule in check mode, so this will fail all four of
them. Could you remove the import? `make format` handles it too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
