sam-1112 opened a new pull request, #6135:
URL: https://github.com/apache/datafusion-comet/pull/6135
## Which issue does this PR close?
Closes #5077.
## Rationale for this change
`allowIncompatible` controls whether the JVM planner may offload casts that
are not guaranteed to be fully compatible. It is a JVM planning decision, but
it was unnecessarily serialized in the `Cast` protobuf and carried through
native cast options despite having no native consumer.
Keeping this unused flag in the JVM-to-native contract obscures the
ownership of the compatibility decision and leaves dead state in the native
cast API.
## What changes are included in this PR?
- Stop serializing `allow_incompat` in `Cast` expressions.
- Reserve the removed protobuf field number and name to preserve wire
compatibility.
- Remove the unused field and constructor parameters from
`SparkCastOptions`.
- Update native call sites, including benchmarks, for the simplified API.
- Remove unused JVM-side helper methods.
- Correct the cast expression audit to state that `allowIncompatible` is
enforced by the JVM planner only.
## How are these changes tested?
No new tests were added because this PR removes unused JVM-to-native
cast-option plumbing and does not change cast behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
