NoahKusaba opened a new pull request, #2473: URL: https://github.com/apache/datafusion-ballista/pull/2473
# Rationale for this change Several lint scripts were checking less than they appeared to. # What changes are included in this PR? - **`dev/release/run-rat.sh`** invoked `python`, not `python3`. With no `python` on PATH the checker never ran, left an empty report, and the script then printed "No unapproved licenses". It now fails when the checker does not run, keeping "found unapproved files" as a separate outcome. - **`ci/scripts/rust_clippy.sh`** named crates one by one, leaving `ballista-api-types`, `ballista-history` and `ballista-chaos` unlinted. It now uses `--workspace`, still linting `ballista-cli` separately because its `tui` and `web` features target different platforms. - **`dev/rust_lint.sh`**, which CONTRIBUTING describes as running all the lints at once, ran four of the seven CI lint scripts. It now runs all seven. - **`pre-commit.sh`** required an uninstalled nightly toolchain for `cargo fmt`. It now uses stable, matching `rust-toolchain.toml` and CI, and no longer refers to "apache arrow". # Are there any user-facing changes? No. Clippy now covers three more crates; they are clean on `main`. Split out of #2438 to make it easier to review. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
