viirya commented on code in PR #6071:
URL: https://github.com/apache/datafusion-comet/pull/6071#discussion_r4064974991
##########
spark/src/main/scala/org/apache/comet/Native.scala:
##########
@@ -77,7 +77,8 @@ class Native extends NativeBase {
taskCPUs: Long,
keyUnwrapper: CometFileKeyUnwrapper,
taskContext: TaskContext,
- classLoader: ClassLoader): Long
+ classLoader: ClassLoader,
+ sharedPlanScope: String = ""): Long
Review Comment:
Fixed in c2e48d2a4225e38436b5669e1af881b468d09838. I missed this existing
assertion when adding `sharedPlanScope`. The test now checks the trailing
`TaskContext`, `ClassLoader`, and `String` parameters and has a name that
reflects the updated signature. The full `CometNativeShuffleSuite` passed
locally on Spark 4.1: 57 tests, 0 failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
