parthchandra commented on PR #6025: URL: https://github.com/apache/datafusion-comet/pull/6025#issuecomment-5737387947
@sunchao agree with your main comments. The hard node-role downgrade is specific to the Iceberg/opendal (`reqsign`) path, which is the reported failure. The pinned Parquet AWS SDK chain retries and stops on a provider error rather than downgrading, so on Parquet the value of the take-over is the raised retry budget plus the shared/coalesced/jittered per-process cache and the explicit no-fallback guarantee — not a downgrade fix. Updated the `s3.rs` comment, the module doc, and `s3-credential-provider-design.md` accordingly. Also fixed the Markdown formatting the CI preflight flagged — `prettier --check` now passes on both edited docs. Validation gaps are unchanged and already called out in the PR: no live STS/S3 integration test (retry / coalescing / no-downgrade are covered by in-memory component tests) and no rerun of the original high-concurrency workload -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
