Smallfu666 commented on PR #5982: URL: https://github.com/apache/datafusion-comet/pull/5982#issuecomment-5733986810
Thanks, all three addressed. 1. Gated the signed-minimum lookup on DataType::is_signed_integer. A signed width missing from signed_integer_min now conservatively reports that it can wrap, so we lose an ordering rather than claim an unsafe one. 2. Filed the legacy scalar divergence as #6015. I verified against Spark 4.1.3 that signed integer negation wraps in non-ANSI mode. 3. Added test_legacy_scalar_negation_of_min_errors_unlike_the_array_path to pin the current scalar/array divergence and link it to #6015. Locally 864 tests pass, and clippy and fmt are clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
