pepijnve commented on PR #25456: URL: https://github.com/apache/datafusion/pull/25456#issuecomment-5727382333
I haven't gone through the code changes in detail yet, but the description sounds like a good way forward. Implementing the assessment once rather than trying to patch things ad hoc per optimiser is the way to go. An open question I still had related to keep-in-place was if this should be refined a bit. On #25388 I tweaked `Expr::placement` so that for simple expressions (unary and binary ops mostly) it is based on the operands placement rather than being keep-in-place. Is that something we would want to take along here? Or should I make a separate PR out of that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
