andygrove commented on PR #5365: URL: https://github.com/apache/datafusion-comet/pull/5365#issuecomment-5647289180
I filed #5882 to settle how the contrib jar is built, versioned and published, since the release scripts never pass `-Pdelta` today and the publish script uploads whatever `install` produces (which is also where the test-jar question lands). It also covers why Delta is packaged differently from Iceberg, which compiles against nothing and ships inside `comet-spark`, and whether that should stay the case. I would rather decide that on purpose in the issue than settle it by default here, so the two packaging points in my review (the `-Pdelta` release line and the unconditional test-jar) can be resolved there rather than blocking this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
