comphead commented on code in PR #2434:
URL:
https://github.com/apache/datafusion-ballista/pull/2434#discussion_r3993772892
##########
ballista/scheduler/src/state/aqe/execution_plan/dynamic_join.rs:
##########
@@ -212,6 +212,15 @@ impl DisplayAs for DynamicJoinSelectionExec {
}
pub enum JoinSelectionAction {
+ /// Shuffle only the prospective build side, leaving the probe side
+ /// untouched, and re-decide the join once the build side's *measured* size
+ /// is known. See [`should_stage_build_side`].
+ StageBuildSide {
+ join: Arc<DynamicJoinSelectionExec>,
+ /// Which child to give an exchange: `true` for `left`, `false` for
+ /// `right`.
+ build_is_left: bool,
Review Comment:
perhaps having enum BuildSide::Left, Right would be more explanatory and
this is generic enum that can be reused it other parts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
