github-actions[bot] commented on PR #25112: URL: https://github.com/apache/datafusion/pull/25112#issuecomment-5608837840
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v55.0.0 (current) Built [ 63.410s] (current) Parsing datafusion v55.0.0 (current) Parsed [ 0.035s] (current) Building datafusion v55.0.0 (baseline) Built [ 63.050s] (baseline) Parsing datafusion v55.0.0 (baseline) Parsed [ 0.037s] (baseline) Checking datafusion v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.610s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 128.910s] datafusion Building datafusion-catalog v55.0.0 (current) Built [ 43.155s] (current) Parsing datafusion-catalog v55.0.0 (current) Parsed [ 0.024s] (current) Building datafusion-catalog v55.0.0 (baseline) Built [ 42.910s] (baseline) Parsing datafusion-catalog v55.0.0 (baseline) Parsed [ 0.025s] (baseline) Checking datafusion-catalog v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.124s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 87.404s] datafusion-catalog Building datafusion-expr v55.0.0 (current) Built [ 31.440s] (current) Parsing datafusion-expr v55.0.0 (current) Parsed [ 0.082s] (current) Building datafusion-expr v55.0.0 (baseline) Built [ 32.053s] (baseline) Parsing datafusion-expr v55.0.0 (baseline) Parsed [ 0.082s] (baseline) Checking datafusion-expr v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 1.228s] 223 checks: 221 pass, 1 fail, 1 warn, 31 skip --- failure enum_variant_added: enum variant added on exhaustive enum --- Description: A publicly-visible enum without #[non_exhaustive] has a new variant. ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/enum_variant_added.ron Failed in: variant DdlStatement:CreateExternalCatalog in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/ddl.rs:54 variant DdlStatement:DropCatalog in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/ddl.rs:64 variant DdlStatement:CreateExternalCatalog in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/ddl.rs:54 variant DdlStatement:DropCatalog in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/ddl.rs:64 --- warning partial_ord_enum_variants_reordered: enum variants reordered in #[derive(PartialOrd)] enum --- Description: A public enum that derives PartialOrd had its variants reordered. #[derive(PartialOrd)] uses the enum variant order to set the enum's ordering behavior, so this change may break downstream code that relies on the previous order. ref: https://doc.rust-lang.org/std/cmp/trait.PartialOrd.html#derivable impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/partial_ord_enum_variants_reordered.ron Failed in: DdlStatement::CreateIndex moved from position 6 to 7, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/ddl.rs:56 DdlStatement::DropTable moved from position 7 to 8, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/ddl.rs:58 DdlStatement::DropView moved from position 8 to 9, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/ddl.rs:60 DdlStatement::DropCatalogSchema moved from position 9 to 10, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/ddl.rs:62 DdlStatement::CreateFunction moved from position 10 to 12, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/ddl.rs:67 DdlStatement::DropFunction moved from position 11 to 13, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/ddl.rs:69 DdlStatement::CreateIndex moved from position 6 to 7, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/ddl.rs:56 DdlStatement::DropTable moved from position 7 to 8, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/ddl.rs:58 DdlStatement::DropView moved from position 8 to 9, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/ddl.rs:60 DdlStatement::DropCatalogSchema moved from position 9 to 10, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/ddl.rs:62 DdlStatement::CreateFunction moved from position 10 to 12, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/ddl.rs:67 DdlStatement::DropFunction moved from position 11 to 13, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/ddl.rs:69 Summary semver requires new major version: 1 major and 0 minor checks failed Warning produced 1 major and 0 minor level warnings Finished [ 66.079s] datafusion-expr Building datafusion-optimizer v55.0.0 (current) Built [ 29.480s] (current) Parsing datafusion-optimizer v55.0.0 (current) Parsed [ 0.032s] (current) Building datafusion-optimizer v55.0.0 (baseline) Built [ 28.939s] (baseline) Parsing datafusion-optimizer v55.0.0 (baseline) Parsed [ 0.033s] (baseline) Checking datafusion-optimizer v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.169s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 59.472s] datafusion-optimizer Building datafusion-proto v55.0.0 (current) Built [ 58.840s] (current) Parsing datafusion-proto v55.0.0 (current) Parsed [ 0.018s] (current) Building datafusion-proto v55.0.0 (baseline) Built [ 58.166s] (baseline) Parsing datafusion-proto v55.0.0 (baseline) Parsed [ 0.019s] (baseline) Checking datafusion-proto v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.124s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 118.369s] datafusion-proto Building datafusion-session v55.0.0 (current) Built [ 41.476s] (current) Parsing datafusion-session v55.0.0 (current) Parsed [ 0.011s] (current) Building datafusion-session v55.0.0 (baseline) Built [ 41.495s] (baseline) Parsing datafusion-session v55.0.0 (baseline) Parsed [ 0.012s] (baseline) Checking datafusion-session v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.183s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 84.182s] datafusion-session Building datafusion-sql v55.0.0 (current) Built [ 46.186s] (current) Parsing datafusion-sql v55.0.0 (current) Parsed [ 0.034s] (current) Building datafusion-sql v55.0.0 (baseline) Built [ 46.094s] (baseline) Parsing datafusion-sql v55.0.0 (baseline) Parsed [ 0.033s] (baseline) Checking datafusion-sql v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.221s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure enum_variant_added: enum variant added on exhaustive enum --- Description: A publicly-visible enum without #[non_exhaustive] has a new variant. ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/enum_variant_added.ron Failed in: variant Statement:CreateExternalCatalog in /home/runner/work/datafusion/datafusion/datafusion/sql/src/parser.rs:405 variant Statement:DropCatalog in /home/runner/work/datafusion/datafusion/datafusion/sql/src/parser.rs:407 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 94.119s] datafusion-sql ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
