rich7420 opened a new pull request, #5799: URL: https://github.com/apache/datafusion-comet/pull/5799
## Which issue does this PR close? Part of #5076. ## Rationale for this change The SQL fixtures lack ANSI coverage for `round`, `conv` and `elt`, including long overflow when rounding to a negative scale. ## What changes are included in this PR? Add ANSI fixtures for rounding overflow, conversion overflow and invalid `elt` indices. Include valid and NULL inputs that check Comet execution, and extend the legacy fixtures with the corresponding boundary cases. ## How are these changes tested? Nine SQL fixtures passed locally on Spark 4.1.3 / JDK 21: the six `round`/`conv`/`elt` fixtures, `arithmetic_ansi.sql` and both boolean-to-decimal fixtures. The latter already cover the other inputs listed in #5076. [Fork CI](https://github.com/rich7420/datafusion-comet/actions/runs/34317911082) completed with 44 successful checks, including the Linux and macOS expressions jobs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
