kosiew commented on code in PR #24820:
URL: https://github.com/apache/datafusion/pull/24820#discussion_r3949350685
##########
datafusion/physical-plan/src/joins/nested_loop_join.rs:
##########
@@ -3440,6 +3534,102 @@ pub(crate) mod tests {
Arc::new(TestMemoryExec::update_cache(&source))
Review Comment:
Could we add an execution-level regression test where the left child emits
multiple sub-target batches, so `JoinLeftData` actually contains more than one
coalesced chunk? It would be useful to exercise both a match and an
unmatched-left row across a chunk boundary.
The new tests do a good job covering buffer reuse and `locate()`, but the
existing join fixtures appear to provide a single build-side `RecordBatch`.
With the smaller batch-size variants, that batch takes the large-batch bypass,
so those tests do not exercise the new chunk transition paths during probing
and final unmatched-left emission.
I am marking this as non-blocking since the global/local index translation
looks consistent on inspection, but an end-to-end test would give us good
regression coverage for the main correctness-sensitive part of this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
