alamb opened a new pull request, #24926:
URL: https://github.com/apache/datafusion/pull/24926

   ## Which issue does this PR close?
   
   - Part of https://github.com/apache/datafusion-sqlparser-rs/issues/2453
   
   Note: this PR is for testing only and is not intended to be merged as-is. 
Once `sqlparser` 0.63.0 is released, the pin will be updated to the released 
version.
   
   ## Rationale for this change
   
   Test DataFusion against the head of 
[apache/datafusion-sqlparser-rs](https://github.com/apache/datafusion-sqlparser-rs)
 ahead of the 0.63.0 release, to find regressions before the release is cut 
(the same exercise as #21960 for 0.62.0). In particular, all queries that 
DataFusion accepts with the current sqlparser release must continue to be 
accepted.
   
   ## What changes are included in this PR?
   
   1. Pin `sqlparser` to git rev `0821cbdd5cbdc27f9c7205466d357deef632c936` 
(current head)
   2. Update DataFusion for upstream AST changes:
      - `OrderByOptions.asc: Option<bool>` is now `sort: Option<OrderBySort>` 
(with a new `OrderBySort::Using` variant, which DataFusion rejects with a "not 
implemented" error)
      - `Expr::Cast` no longer has the `array` field
      - `DataType::Map` gained a `MapBracketKind` field
      - `SelectInto.name: ObjectName` is now `targets: Vec<Expr>`; DataFusion 
supports a single table-name target and rejects the rest
      - `MergeUpdateExpr.assignments` is now `kind: MergeUpdateKind`; the new 
`UPDATE SET *` / `INSERT *` merge forms are rejected with "not implemented" 
errors
      - `UniqueConstraint`/`PrimaryKeyConstraint` gained `include`, 
`CheckConstraint` gained `no_inherit` (ignored, like other index metadata 
fields)
      - New `TableConstraint::Exclude` and `FunctionArgumentClause::Where` 
variants are rejected with "not implemented" errors
      - `CreateTable` gained `unlogged`, `with_connection`, `multiset`, 
`fallback` and `with_data` fields, which are rejected when set
   
   ## What is the testing strategy for this PR?
   
   Existing CI (including sqllogictests) run against the new sqlparser version.
   
   ## Are there any user-facing changes?
   
   No (testing PR, not intended for merge).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to