NoahKusaba opened a new pull request, #2408:
URL: https://github.com/apache/datafusion-ballista/pull/2408
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
The three benchmark workflows each inlined the same ~60 lines of setup and
cluster lifecycle. This extracts the shared halves into
`.github/actions/setup-benchmark-builder` (deps, toolchain, cache, build) and
`ci/scripts/ballista_cluster.sh` (`start` / `stop`). Workflows drop from ~90
lines of job body to ~40.
`stop` is now its own step under `if: always()`, so teardown and the log dump
also happen on a timeout or cancellation. The old `trap cleanup EXIT` only
fired if the step's own shell exited.
Fixes drift the three copies had accumulated:
- tpch and h2o uploaded logs under `failure()`, discarding them on a hang,
which is the case they exist for. Now `!success()`, matching tpcds.
- tpch and h2o had no timeouts (6-hour default). All three now 45min job /
30min step; observed passing jobs are 8-23min.
- tpcds used `--concurrent-tasks`, a deprecated alias that warns. Now
`--vcores`.
Also fixes two readiness bugs present in all three copies. A dead process was
waited on for the full 30s instead of failing immediately, and an open port
was
treated as proof of health (the executor binds its gRPC port before the
Flight
server and exits if that later bind fails).
No new third-party actions, the composite reuses the rust-cache pin already
used across the repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
