alexandrefimov opened a new pull request, #24855:
URL: https://github.com/apache/datafusion/pull/24855

   ## Which issue does this PR close?
   
   None — the documented command does not run, so this is a straight 
documentation fix.
   
   ## Rationale for this change
   
   The sqllogictest README documents the Substrait round-trip mode as
   
   ```shell
   cargo test --test sqllogictests -- --substrait-round-trip
   ```
   
   but the round-trip path is behind the `substrait` feature, which is not in 
`default`. Run as documented, every file fails with `Cannot run substrait 
round-trip: the 'substrait' feature is not enabled` — 505 of them on today's 
`main`, which reads as the mode being thoroughly broken rather than as a 
missing flag.
   
   The same section points at #16248 for the failures. That epic is now 16 of 
its 21 sub-issues closed, while the mode still fails on classes it never 
listed, so the sentence promises more than the link delivers.
   
   ## What changes are included in this PR?
   
   Both documented commands get `--features substrait`, and the warning says 
where the mode lives and that #16248 collects some of the failures rather than 
all of them.
   
   ## What is the testing strategy for this PR?
   
   Ran both documented forms on `main` with the flag: the full form completes 
the suite and the `binary.slt` filter runs three files. 
`ci/scripts/doc_prettier_check.sh` passes.
   
   ## Are there any user-facing changes?
   
   Documentation only.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to