rluvaton commented on issue #24704: URL: https://github.com/apache/datafusion/issues/24704#issuecomment-5469067191
We can have `EmitTo::All` if we have a signature that return Vec<Blocks> in that case Emit all can still be valuable since accumulators might include more tracking data (like unique values for distinct) and emitting all will release those and we can move the blocks memory tracking to the caller `EmitTo::First(n)` if we have a signature that return Vec<Blocks> in the case than `n` is larger than `block_size` but I think we `n` must not be larger than block size and it should return Block so users would need to call emit next block with n as the remainder -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
