sunchao commented on PR #5452: URL: https://github.com/apache/datafusion-comet/pull/5452#issuecomment-5464414171
The final pass of `ec9832366` identified two **P1 issues**, now recorded with reproductions and validation limits in [#5544](https://github.com/apache/datafusion-comet/issues/5544#issuecomment-5464398708): - Newly admitted malformed UTF-8 map literals can reach native string operations and abort the JVM with **SIGABRT**. This was reproduced with the debug native build; release-build failure behavior was not tested. - The ANSI `element_at` guard reevaluates nullable stateful operands, silently changing values and NULL placement in already-supported primitive-array queries. A simple counter example returns only four of eight expected non-NULL values. This raises the priority of the previously reported stateful-operand P2. Both were independently reproduced on Spark 4.1.3 / JDK 17, and the exact-base serializer controls pass on the same native/JVM runtime. Those controls are not a full base build. These results change my earlier LGTM recommendation: I recommend restoring safe fallback for these cases before merging. The broader fixes can remain follow-ups in #5544. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
