kumarUjjawal commented on code in PR #24700:
URL: https://github.com/apache/datafusion/pull/24700#discussion_r3885558838
##########
datafusion/physical-expr/src/expressions/case.rs:
##########
@@ -1437,8 +1447,8 @@ impl PhysicalExpr for CaseExpr {
})
})
.collect::<Result<Vec<_>>>()?,
- else_expr: self
- .else_expr()
+ else_expr: else_expr
Review Comment:
The CASE proto tests cannot tell `expr` from `else_expr`, because the stubs
emit an identical node and the fixture sets both to `Some`. I think a fixture
with no base expression and no ELSE would be helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
