kosiew commented on code in PR #24700:
URL: https://github.com/apache/datafusion/pull/24700#discussion_r3880603379
##########
datafusion/physical-expr/src/expressions/in_list.rs:
##########
@@ -479,13 +484,21 @@ impl PhysicalExpr for InListExpr {
) -> Result<Option<datafusion_proto_models::protobuf::PhysicalExprNode>> {
use datafusion_proto_models::protobuf;
+ let Self {
+ expr,
+ list,
+ negated,
+ // Lookup set rebuilt from `list` by `try_new` on decode.
+ static_filter: _,
+ } = self;
+
Ok(Some(protobuf::PhysicalExprNode {
expr_id: None,
expr_type:
Some(protobuf::physical_expr_node::ExprType::InList(Box::new(
protobuf::PhysicalInListNode {
- expr: Some(Box::new(ctx.encode_child(&self.expr)?)),
- list: ctx.encode_children_expressions(&self.list)?,
- negated: self.negated,
+ expr: Some(Box::new(ctx.encode_child(expr)?)),
+ list: ctx.encode_children_expressions(list)?,
+ negated: *negated,
Review Comment:
Could we also add an encode fixture or assertion with `negated: true`? The
current encode fixture only covers `false`, so an implementation that
accidentally hardcodes or defaults the serialized value to `false` would still
pass. The decode test covers `true`, but that doesn't exercise the encode path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
