cj-zhukov commented on code in PR #24633:
URL: https://github.com/apache/datafusion/pull/24633#discussion_r3883428937
##########
datafusion/core/tests/dataframe/mod.rs:
##########
@@ -6982,10 +6982,10 @@ async fn test_dataframe_from_columns() -> Result<()> {
("f32", f32s),
("f64", f64s),
("str", strings),
- ])?;
+ ];
- assert_eq!(df.schema().fields().len(), 13);
- assert_eq!(df.clone().count().await?, 3);
+ let df1 = DataFrame::from_columns(columns.clone())?;
Review Comment:
I agree, it makes sense to extend the tests to cover the `IntoIterator` API.
Since I'm keeping the existing `(&str, ArrayRef)` item type for compatibility,
I'll add a test with a non-collection iterator using `.into_iter().map(...)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
