sunchao commented on PR #5457: URL: https://github.com/apache/datafusion-comet/pull/5457#issuecomment-5455253906
Addressed the remaining fixture and documentation follow-ups in [696c00522](https://github.com/apache/datafusion-comet/commit/696c00522f76d091ccbab7a72d4883ef7a9eabe0). The five affected NTZ expression fixtures now reuse the existing wrapped or materialized input helpers, with their native operator assertions retained. The cast documentation sources now describe the fixed whole-minute timezone requirement and the DATE-to-NTZ row-execution and TRY_CAST limits. The scan and cast safety guards are unchanged. Validation: all five formerly failing fixtures pass on Spark 3.4 and 4.1. The focused selections passed 7 tests on Spark 3.4 and 27 on Spark 4.1, including the relevant cast admission checks. Fresh GenerateDocs output includes the timezone restriction in all three cast modes and the corrected NTZ wording. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
