kosiew commented on code in PR #24696:
URL: https://github.com/apache/datafusion/pull/24696#discussion_r3880532325
##########
datafusion/datasource-arrow/src/source.rs:
##########
@@ -414,7 +414,17 @@ impl FileSource for ArrowSource {
use datafusion_proto_models::protobuf;
use protobuf::physical_plan_node::PhysicalPlanType;
- let format = match self.format {
+ let Self {
Review Comment:
Could we add a short comment explaining that this exhaustive destructure is
intentional and acts as a compile-time guard? That would make it clearer to
future readers that a newly added `ArrowSource` field needs to be explicitly
considered by this serde hook, rather than being serialized automatically. It
would be nice to add the same comment to the equivalent `AvroSource`
destructure as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
