buraksenn opened a new pull request, #24696:
URL: https://github.com/apache/datafusion/pull/24696

   ## Which issue does this PR close?
   
   - Closes #24622.
   
   ## Rationale for this change
   
   Proto hooks that access fields individually can silently omit newly added 
state. Exhaustive destructuring makes such omissions compile errors.
   
   ## What changes are included in this PR?
   
   - Exhaustively destructure `ArrowSource` and `AvroSource` in their encoders.
   - Exhaustively destructure their protobuf nodes in the decoders.
   - Document why non-serialized fields are excluded.
   
   The wire format is unchanged.
   
   ## Are these changes tested?
   
   Covered by the existing Arrow and Avro round-trip tests:
   
   ```bash
   cargo test -p datafusion-proto --test proto_integration --features avro 
roundtrip_arrow
   cargo test -p datafusion-proto --test proto_integration --features avro 
roundtrip_avro
   ```
   
   The standard lint suite also passes:
   
   ```bash
   ./dev/rust_lint.sh
   ```
   
   ## Are there any user-facing changes?
   
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to