kosiew commented on code in PR #24600:
URL: https://github.com/apache/datafusion/pull/24600#discussion_r3880463967
##########
datafusion/physical-expr/src/partitioning.rs:
##########
@@ -1291,6 +1366,68 @@ mod tests {
Ok(())
}
+
+ #[test]
+ fn test_range_partitioning_adapt() {
Review Comment:
Could we add a slightly broader test here? `test_range_partitioning_adapt`
currently covers a single key with default sort options. It would be useful to
add a two-key case with non-default `SortOptions` and typed NULL split values,
then assert that the adapted ordering preserves the sort options for each key.
That would give us direct coverage of the new zip and copy path beyond the
current single-key happy path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
