mattisonchao opened a new pull request, #24751: URL: https://github.com/apache/datafusion/pull/24751
## Which issue does this PR close? - Part of #24209. ## Rationale for this change UDF argument names are copied into generated function documentation. Hyphenated names make the documentation inconsistent with the underscore style used by SQL syntax, and the repository currently has no automated check preventing them from being reintroduced. ## What changes are included in this PR? Adds a function-documentation test that scans the scalar, higher-order, aggregate, and window UDF registries and reports any hyphenated argument name, directing contributors to use underscores. The existing SQL table-format test now shares the same registry traversal helper. ## Are these changes tested? Yes. - `cargo test -p datafusion --test core_integration function_docs::` - `cargo fmt --all` - `cargo clippy --all-targets --all-features -- -D warnings` - `./dev/rust_lint.sh` - `RUST_BACKTRACE=1 cargo test --profile ci --exclude datafusion-examples --exclude datafusion-benchmarks --exclude datafusion-cli --workspace --lib --tests --bins --features avro,json,backtrace,extended_tests,recursive_protection,parquet_encryption` The new assertion was also verified by temporarily changing `sub_array` to `sub-array`; it failed with `array_has_all: sub-array` as expected. ## Are there any user-facing changes? No. This validates repository-owned generated documentation metadata and does not change SQL behavior or public APIs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
