andygrove commented on PR #5407: URL: https://github.com/apache/datafusion-comet/pull/5407#issuecomment-5444218625
Correction on my last comment: the CI point was wrong. The Spark 4.0 jobs run with `pushVariantIntoScan=false` as the real default, so the native path is genuinely covered there, and `variant.sql` already asserts the pushdown=true fallback explicitly. Pinning the conf in the tests is the right call. What I still think is worth addressing is the 4.1/4.2 side. On those versions a user needs to set an internal conf to get any of this, so the description and user docs should say so, and the benchmark numbers should be labelled with it. The question about recognizing the one-field pushed struct, or filing a follow-up issue for it, still stands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
