github-actions[bot] commented on PR #24633: URL: https://github.com/apache/datafusion/pull/24633#issuecomment-5399858287
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v55.0.0 (current) Built [ 60.538s] (current) Parsing datafusion v55.0.0 (current) Parsed [ 0.038s] (current) Building datafusion v55.0.0 (baseline) Built [ 60.221s] (baseline) Parsing datafusion v55.0.0 (baseline) Parsed [ 0.040s] (baseline) Checking datafusion v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.934s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure method_requires_different_generic_type_params: method now requires a different number of generic type parameters --- Description: A method now requires a different number of generic type parameters than it used to. Uses of this method that supplied the previous number of generic types will be broken. ref: https://doc.rust-lang.org/reference/items/generics.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/method_requires_different_generic_type_params.ron Failed in: datafusion::prelude::dataframe::DataFrame::from_columns takes 2 generic types instead of 0, in /home/runner/work/datafusion/datafusion/datafusion/core/src/dataframe/mod.rs:2631 datafusion::dataframe::DataFrame::from_columns takes 2 generic types instead of 0, in /home/runner/work/datafusion/datafusion/datafusion/core/src/dataframe/mod.rs:2631 datafusion::prelude::DataFrame::from_columns takes 2 generic types instead of 0, in /home/runner/work/datafusion/datafusion/datafusion/core/src/dataframe/mod.rs:2631 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 123.604s] datafusion ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
