iffyio commented on code in PR #2361:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2361#discussion_r3841446510
##########
src/ast/query.rs:
##########
@@ -756,11 +756,23 @@ pub struct With {
pub recursive: bool,
/// The list of CTEs declared by this `WITH` clause.
pub cte_tables: Vec<Cte>,
+ /// Optional XML namespace definitions (`WITH XMLNAMESPACES (...)`).
+ pub xml_namespaces: Vec<XmlNamespaceDefinition>,
Review Comment:
hmm the latest diff isn't what I meant, to clarify I don't think we should
have `pub xml_namespaces: Vec<XmlNamespaceDefinition>` or a new field at all.
basically I meant that we implement effectively what's in the linked PR if that
absorbs this feature (i.e. the assumption is that xml_namespace is simply a
CSE?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
