ariel-miculas commented on code in PR #23606:
URL: https://github.com/apache/datafusion/pull/23606#discussion_r3720497093
##########
datafusion/execution/src/memory_pool/mod.rs:
##########
@@ -36,6 +37,7 @@ pub mod proxy {
pub use datafusion_common::{
human_readable_count, human_readable_duration, human_readable_size, units,
};
+pub use peak_recording::*;
Review Comment:
> Could we keep it in the benchmark utilities and use a small local helper
in the test instead?
I'm not a fan of implementing another memory pool just for this single use
case (although I'm aware it wouldn't be difficult in the LLM age), especially
since someone already solved this problem by implementing the
PeakRecordingPool. I don't know if we need to expose it as a public API, but I
see no reason to keep it in benchmarks if I need it for the fuzz tests in
datafusion-core
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
