ariel-miculas commented on PR #23606: URL: https://github.com/apache/datafusion/pull/23606#issuecomment-5180630141
> Overall this looks good. I noticed a related existing issue the round-robin setting can be lost when we rebuilds the merge operator, it can remove the memory benefit added here. This PR doesn't really bring any memory benefit (since round robin tie breaking is enabled by default), its purpose is to show the memory overhead caused by the exising design. My goal with this PR is to make it clear how the [next PR](https://github.com/apache/datafusion/pull/23619) reduces the memory overhead with round robin tie breaking enabled -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
