buraksenn commented on code in PR #23918:
URL: https://github.com/apache/datafusion/pull/23918#discussion_r3712869735
##########
datafusion/core/src/physical_planner.rs:
##########
@@ -4142,7 +4142,7 @@ mod tests {
.expect_err("planning error")
.strip_backtrace();
- insta::assert_snapshot!(e, @r#"Error during planning: Extension
planner for NoOp created an ExecutionPlan with mismatched schema. LogicalPlan
schema: DFSchema { inner: Schema { fields: [Field { name: "a", data_type: Int32
}], metadata: {} }, field_qualifiers: [None], functional_dependencies:
FunctionalDependencies { deps: [] } }, ExecutionPlan schema: Schema { fields:
[Field { name: "b", data_type: Int32 }], metadata: {} }"#);
+ insta::assert_snapshot!(e, @r#"Error during planning: Extension
planner for NoOp created an ExecutionPlan with mismatched schema. LogicalPlan
schema: DFSchema { inner: Schema { fields: [Field { name: "a", data_type: Int32
}], metadata: {} }, field_qualifiers: [None], functional_dependencies:
FunctionalDependencies { deps: [], null_equalities: [] } }, ExecutionPlan
schema: Schema { fields: [Field { name: "b", data_type: Int32 }], metadata: {}
}"#);
Review Comment:
I've moved it int other FunctionalDependence struct which also simplified
the PR imo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
