kosiew commented on code in PR #23719:
URL: https://github.com/apache/datafusion/pull/23719#discussion_r3663803502
##########
datafusion/physical-plan/src/display.rs:
##########
@@ -234,6 +240,15 @@ impl<'a> DisplayableExecutionPlan<'a> {
self
}
+ /// Specify which metric names to include.
Review Comment:
Nice addition! One small suggestion: it may be worth mentioning here that
metric name filtering is intersected with the existing metric type and category
filters. That helps explain why a requested metric name may still not appear if
another active filter excludes it. I think that would make the behaviour a
little clearer for snapshot test users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
