peterxcli commented on PR #5030: URL: https://github.com/apache/datafusion-comet/pull/5030#issuecomment-5079559185
> make_interval was considered but left for a follow-up: its output type is CalendarIntervalType, which Comet's columnar layer does not yet support (the dispatcher reports unsupported output type CalendarIntervalType and falls back). It can be enabled once CalendarIntervalType support lands (https://github.com/apache/datafusion-comet/pull/4898). I think you're https://github.com/apache/datafusion-comet/issues/3099 refer to this? I saw the native `SparkMakeInterval` implementation is ready and registered as comet udf, what we need to do add a new catalyst mapping `classOf[MakeInterval] -> CometMakeInterval` and `CometMakeInterval` scala implementation to convert expr to `make_interval` proto? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
