avantgardnerio commented on code in PR #2175:
URL:
https://github.com/apache/datafusion-ballista/pull/2175#discussion_r3650239674
##########
ballista/scheduler/src/state/execution_stage.rs:
##########
@@ -218,6 +219,10 @@ pub struct RunningStage {
pub stage_metrics: Option<Vec<MetricsSet>>,
/// [SessionConfig] used for this stage
pub session_config: Arc<SessionConfig>,
+ /// `RuntimeStatsReport`s collected from every successful task in
+ /// this stage attempt. Merged and logged once the stage finalizes;
+ /// dropped when the stage transitions to Successful.
+ pub runtime_stats_reports: Vec<RuntimeStatsReport>,
Review Comment:
The only instance I could find of this being struct literal'ed was in
`SuccessfulStage::to_running()`. I don't think we can guarantee no one external
does it, but it seems like largely an internal concern to the scheduler, so
downstream users literaling it seem unlikely. We could probably make it
non-pub, but that seems more likely to break things. My bet is that the least
disruptive thing to do is leave it as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
