avantgardnerio commented on code in PR #2175:
URL:
https://github.com/apache/datafusion-ballista/pull/2175#discussion_r3650221352
##########
ballista/executor/src/lib.rs:
##########
@@ -103,21 +103,25 @@ pub struct TaskExecutionTimes {
/// This function wraps the outcome of task execution (success or failure)
/// along with timing and metrics information into a status message that
/// can be sent back to the scheduler.
+#[allow(clippy::too_many_arguments)]
pub fn as_task_status(
execution_result: ballista_core::error::Result<Vec<ShuffleWritePartition>>,
executor_id: String,
stage_attempt_num: usize,
key: TaskKey,
operator_metrics: Option<Vec<OperatorMetricsSet>>,
+ runtime_stats: Vec<RuntimeStatsReport>,
Review Comment:
Thanks! I'll add `api-change` to my mental checklist henceforth. I think I
resolved this in a way that matches your suggestion. Let me know if I missed
something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
