iffyio commented on code in PR #2356:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2356#discussion_r3650032791
##########
src/ast/mod.rs:
##########
@@ -1108,14 +1108,9 @@ pub enum Expr {
kind: CastKind,
/// Expression being cast.
expr: Box<Expr>,
- /// Target data type.
+ /// Target data type. A trailing `ARRAY` keyword (e.g.
+ /// `CAST(... AS UNSIGNED ARRAY)`) becomes
[`ArrayElemTypeDef::Qualified`].
Review Comment:
```suggestion
/// Target data type.
```
i think the succint description was clear enough in this case, singling out
the qualified array case here reads somewhat arbitrary without the context of
this PR (which future readers wont be interested in)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
