LucaCappelletti94 commented on code in PR #2356:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2356#discussion_r3649991312
##########
src/dialect/generic.rs:
##########
@@ -209,6 +209,10 @@ impl Dialect for GenericDialect {
true
}
+ fn supports_array_typedef_with_keyword(&self) -> bool {
Review Comment:
I generally tend to prefer keeping things as strict as possible, but I
understand the general mantra of this parser is permissiveness.
I dropped `supports_array_typedef_with_keyword` entirely and now accept `T
ARRAY` / `T ARRAY[n]` in every dialect. The bracket form stays gated since `[`
clashes with identifier quoting in MSSQL and SQLite, but the `ARRAY` keyword
has no such clash.
This means that every dialect now also parses `T ARRAY[4]`, including MySQL
where only the bare `T ARRAY` is real SQL. No test treats that as an error, and
I am not sure whether this is a good choice or not.
Again, I understand I tend to lean on strictness so maybe I am worrying over
nothing. LMK your opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
