comphead commented on code in PR #5014:
URL: https://github.com/apache/datafusion-comet/pull/5014#discussion_r3646298031
##########
native/spark-expr/src/conversion_funcs/string.rs:
##########
@@ -1930,6 +1929,31 @@ fn date_parser(date_str: &str, eval_mode: EvalMode) ->
SparkResult<Option<i32>>
Ok(None)
}
}
+
+ /// Turns parsed year/month/day segments into an epoch day. Shared by both
parsing paths so
+ /// that the decision of what a segment triple *means* lives in exactly
one place.
+ fn finish(
+ year: i64,
Review Comment:
`chrono` usually uses `u32`
https://docs.rs/chrono/latest/chrono/trait.Datelike.html#tymethod.with_day
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
