zhuqi-lucas commented on PR #23840:
URL: https://github.com/apache/datafusion/pull/23840#issuecomment-5069347450

   cc @alamb @Dandandan @adriangb 
   The benchmark result looks good for all sort tpch:
   ```rust
   Comparing HEAD and perf_spm-cursor-cache
   --------------------
   Benchmark sort_tpch10.json
   --------------------
   
┏━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
   ┃ Query ┃                                   HEAD ┃                  
perf_spm-cursor-cache ┃        Change ┃
   
┡━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
   │ Q1    │   1677.24 / 1686.65 ±6.27 / 1692.93 ms │   1447.63 / 1453.98 ±6.00 
/ 1462.64 ms │ +1.16x faster │
   │ Q2    │  1434.14 / 1485.32 ±30.98 / 1531.50 ms │  1344.79 / 1405.06 ±36.30 
/ 1459.31 ms │ +1.06x faster │
   │ Q3    │ 8682.89 / 8946.53 ±229.28 / 9317.35 ms │ 8156.20 / 8402.95 ±394.56 
/ 9186.46 ms │ +1.06x faster │
   │ Q4    │  2837.44 / 2871.31 ±28.39 / 2907.75 ms │  2290.31 / 2331.32 ±51.80 
/ 2432.89 ms │ +1.23x faster │
   │ Q5    │  2636.96 / 2669.74 ±28.34 / 2718.19 ms │  2358.64 / 2392.49 ±33.02 
/ 2441.65 ms │ +1.12x faster │
   │ Q6    │  2771.19 / 2806.44 ±29.19 / 2856.34 ms │  2501.99 / 2524.75 ±27.01 
/ 2575.83 ms │ +1.11x faster │
   │ Q7    │ 5522.92 / 5633.12 ±131.25 / 5868.53 ms │ 5205.39 / 5408.01 ±188.13 
/ 5667.43 ms │     no change │
   │ Q8    │  4032.72 / 4116.58 ±56.40 / 4190.26 ms │  3482.46 / 3630.69 ±92.15 
/ 3737.70 ms │ +1.13x faster │
   │ Q9    │  4430.32 / 4558.74 ±88.72 / 4671.22 ms │  3903.63 / 3950.55 ±43.99 
/ 4006.53 ms │ +1.15x faster │
   │ Q10   │ 6805.83 / 7191.19 ±209.76 / 7421.33 ms │ 6256.48 / 6834.18 ±337.04 
/ 7314.72 ms │     no change │
   │ Q11   │  3518.08 / 3592.09 ±67.05 / 3705.90 ms │  3125.97 / 3168.47 ±77.12 
/ 3322.47 ms │ +1.13x faster │
   
└───────┴────────────────────────────────────────┴────────────────────────────────────────┴───────────────┘
   ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
   ┃ Benchmark Summary                    ┃            ┃
   ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
   │ Total Time (HEAD)                    │ 45557.72ms │
   │ Total Time (perf_spm-cursor-cache)   │ 41502.47ms │
   │ Average Time (HEAD)                  │  4141.61ms │
   │ Average Time (perf_spm-cursor-cache) │  3772.95ms │
   │ Queries Faster                       │          9 │
   │ Queries Slower                       │          0 │
   │ Queries with No Change               │          2 │
   │ Queries with Failure                 │          0 │
   └──────────────────────────────────────┴────────────┘
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to