mbutrovich commented on code in PR #5003:
URL: https://github.com/apache/datafusion-comet/pull/5003#discussion_r3640914744
##########
native/shuffle/src/writers/buf_batch_writer.rs:
##########
@@ -28,7 +28,9 @@ use std::io::{Cursor, Seek, SeekFrom, Write};
///
/// Small batches are coalesced using Arrow's [`BatchCoalescer`] before
serialization,
/// producing exactly `batch_size`-row output batches to reduce per-block IPC
schema overhead.
Review Comment:
"producing exactly `batch_size`-row output batches" is not accurate once a
`>= batch_size` batch is bypassed verbatim, which the single-partition path
already does today. Could soften to "at least `batch_size`" and mention the
passthrough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
