mbutrovich commented on PR #5003: URL: https://github.com/apache/datafusion-comet/pull/5003#issuecomment-5062645101
> output bytes are identical to before True for multi-partition and spill. For single-partition, a `>= batch_size` batch on an empty coalescer buffer now yields one oversized block instead of `batch_size`-row blocks, because `single_partition.rs:107-108` already routes such batches straight to the coalescer on `main`. Worth qualifying the claim so it does not read as unconditional. Rows still roundtrip in order, so this is a block-boundary and buffer-size change, not a correctness issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
