phillipleblanc commented on code in PR #1893:
URL:
https://github.com/apache/datafusion-ballista/pull/1893#discussion_r3611669527
##########
ballista/scheduler/src/scheduler_server/query_stage_scheduler.rs:
##########
@@ -295,6 +300,13 @@ impl<T: 'static + AsLogicalPlan, U: 'static +
AsExecutionPlan>
.await?;
}
+ // Notify external systems when new stages become
runnable
+ if !stage_events.is_empty()
+ && let Some(ref callback) =
self.config.on_work_available
+ {
+ callback("tasks_completed:new_stages_runnable");
+ }
+
Review Comment:
This is correct, changed to remove the callback from `TaskUpdating` and
moved into the `JobUpdated` arm, assuming `update_job` returns `new_tasks > 0`.
So this only notifies when stages genuinely had new scheduleable tasks, and
only after they are updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
