phillipleblanc commented on code in PR #1893:
URL:
https://github.com/apache/datafusion-ballista/pull/1893#discussion_r3611667677
##########
ballista/executor/src/execution_loop.rs:
##########
@@ -204,7 +208,20 @@ where
}
if !active_job {
- tokio::time::sleep(Duration::from_millis(50)).await;
+ // Wait for either the poll interval or a poll_now notification
+ match &poll_now_notify {
+ Some(notify) => {
+ tokio::select! {
+ () = tokio::time::sleep(Duration::from_millis(50)) =>
{}
Review Comment:
Agreed, implemented to use a 1s fallback if a `poll_now_notify` is provided,
otherwise unchanged at 50ms to preserve existing behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
