github-actions[bot] commented on PR #23703: URL: https://github.com/apache/datafusion/pull/23703#issuecomment-5017202856
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v54.0.0 (current) Built [ 97.499s] (current) Parsing datafusion v54.0.0 (current) Parsed [ 0.033s] (current) Building datafusion v54.0.0 (baseline) Built [ 97.176s] (baseline) Parsing datafusion v54.0.0 (baseline) Parsed [ 0.033s] (baseline) Checking datafusion v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.885s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 198.516s] datafusion Building datafusion-catalog v54.0.0 (current) Built [ 36.194s] (current) Parsing datafusion-catalog v54.0.0 (current) Parsed [ 0.023s] (current) Building datafusion-catalog v54.0.0 (baseline) Built [ 36.227s] (baseline) Parsing datafusion-catalog v54.0.0 (baseline) Parsed [ 0.025s] (baseline) Checking datafusion-catalog v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.168s] 223 checks: 221 pass, 2 fail, 0 warn, 30 skip --- failure struct_missing: pub struct removed or renamed --- Description: A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/struct_missing.ron Failed in: struct datafusion_catalog::TableFunction, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/69ad9c0d9a1eaf0d1e99353644bc42465f437ce8/datafusion/catalog/src/table.rs:600 struct datafusion_catalog::ScanArgs, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/69ad9c0d9a1eaf0d1e99353644bc42465f437ce8/datafusion/catalog/src/table.rs:406 struct datafusion_catalog::TableFunctionArgs, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/69ad9c0d9a1eaf0d1e99353644bc42465f437ce8/datafusion/catalog/src/table.rs:554 struct datafusion_catalog::ScanResult, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/69ad9c0d9a1eaf0d1e99353644bc42465f437ce8/datafusion/catalog/src/table.rs:502 --- failure trait_missing: pub trait removed or renamed --- Description: A publicly-visible trait cannot be imported by its prior path. A `pub use` may have been removed, or the trait itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/trait_missing.ron Failed in: trait datafusion_catalog::CatalogProviderList, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/69ad9c0d9a1eaf0d1e99353644bc42465f437ce8/datafusion/catalog/src/catalog.rs:175 trait datafusion_catalog::TableProvider, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/69ad9c0d9a1eaf0d1e99353644bc42465f437ce8/datafusion/catalog/src/table.rs:52 trait datafusion_catalog::SchemaProvider, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/69ad9c0d9a1eaf0d1e99353644bc42465f437ce8/datafusion/catalog/src/schema.rs:37 trait datafusion_catalog::CatalogProvider, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/69ad9c0d9a1eaf0d1e99353644bc42465f437ce8/datafusion/catalog/src/catalog.rs:108 trait datafusion_catalog::TableFunctionImpl, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/69ad9c0d9a1eaf0d1e99353644bc42465f437ce8/datafusion/catalog/src/table.rs:579 trait datafusion_catalog::TableProviderFactory, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/69ad9c0d9a1eaf0d1e99353644bc42465f437ce8/datafusion/catalog/src/table.rs:544 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 74.060s] datafusion-catalog Building datafusion-datasource v54.0.0 (current) Built [ 35.531s] (current) Parsing datafusion-datasource v54.0.0 (current) Parsed [ 0.029s] (current) Building datafusion-datasource v54.0.0 (baseline) Built [ 35.238s] (baseline) Parsing datafusion-datasource v54.0.0 (baseline) Parsed [ 0.031s] (baseline) Checking datafusion-datasource v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.336s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 72.641s] datafusion-datasource Building datafusion-datasource-arrow v54.0.0 (current) Built [ 36.143s] (current) Parsing datafusion-datasource-arrow v54.0.0 (current) Parsed [ 0.011s] (current) Building datafusion-datasource-arrow v54.0.0 (baseline) Built [ 35.264s] (baseline) Parsing datafusion-datasource-arrow v54.0.0 (baseline) Parsed [ 0.012s] (baseline) Checking datafusion-datasource-arrow v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.091s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 72.878s] datafusion-datasource-arrow Building datafusion-ffi v54.0.0 (current) Built [ 55.313s] (current) Parsing datafusion-ffi v54.0.0 (current) Parsed [ 0.057s] (current) Building datafusion-ffi v54.0.0 (baseline) Built [ 54.221s] (baseline) Parsing datafusion-ffi v54.0.0 (baseline) Parsed [ 0.057s] (baseline) Checking datafusion-ffi v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.331s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 112.040s] datafusion-ffi Building datafusion-session v54.0.0 (current) Built [ 33.646s] (current) Parsing datafusion-session v54.0.0 (current) Parsed [ 0.011s] (current) Building datafusion-session v54.0.0 (baseline) Built [ 33.000s] (baseline) Parsing datafusion-session v54.0.0 (baseline) Parsed [ 0.009s] (baseline) Checking datafusion-session v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.118s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip --- failure trait_method_added: pub trait method added --- Description: A non-sealed public trait added a new method without a default implementation, which breaks downstream implementations of the trait ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-new-item-no-default impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/trait_method_added.ron Failed in: trait method datafusion_session::session::Session::catalog_list in file /home/runner/work/datafusion/datafusion/datafusion/session/src/session.rs:85 trait method datafusion_session::Session::catalog_list in file /home/runner/work/datafusion/datafusion/datafusion/session/src/session.rs:85 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 68.326s] datafusion-session ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
