andygrove commented on code in PR #4799:
URL: https://github.com/apache/datafusion-comet/pull/4799#discussion_r3589264407
##########
spark/src/main/scala/org/apache/comet/serde/predicates.scala:
##########
@@ -119,6 +128,8 @@ object CometEqualTo extends CometExpressionSerde[EqualTo] {
}
object CometEqualNullSafe extends CometExpressionSerde[EqualNullSafe] {
+ override def getSupportLevel(expr: EqualNullSafe): SupportLevel =
+ ComparisonUtils.collationSupportLevel(expr.left, expr.right)
override def convert(
expr: EqualNullSafe,
inputs: Seq[Attribute],
Review Comment:
These changes look good and probably should be separate PR since this is
unrelated to legacy configs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
