andygrove commented on code in PR #4799:
URL: https://github.com/apache/datafusion-comet/pull/4799#discussion_r3589245649


##########
dev/diffs/4.0.2.diff:
##########
@@ -1374,6 +1374,28 @@ index 2e33f6505ab..be967565303 100644
      }
  
      withTable("t1", "t2") {
+diff --git 
a/sql/core/src/test/scala/org/apache/spark/sql/VariantEndToEndSuite.scala 
b/sql/core/src/test/scala/org/apache/spark/sql/VariantEndToEndSuite.scala
+index a40e34d94d0..d3b3c0801bb 100644
+--- a/sql/core/src/test/scala/org/apache/spark/sql/VariantEndToEndSuite.scala
++++ b/sql/core/src/test/scala/org/apache/spark/sql/VariantEndToEndSuite.scala
+@@ -17,6 +17,7 @@
+ package org.apache.spark.sql
+ 
+ import org.apache.spark.{SparkException, SparkRuntimeException}
++import org.apache.spark.sql.IgnoreComet
+ import org.apache.spark.sql.QueryTest.sameRows
+ import org.apache.spark.sql.catalyst.InternalRow
+ import org.apache.spark.sql.catalyst.expressions.{Cast, Literal}
+@@ -340,7 +341,8 @@ class VariantEndToEndSuite extends QueryTest with 
SharedSparkSession {
+     dataVector.close()
+   }
+ 
+-  test("cast to variant/to_variant_object with scan input") {
++  test("cast to variant/to_variant_object with scan input",
++      IgnoreComet("\"VariantType\" not supported")) {

Review Comment:
   This seems like a regression. This test was previously passing because we 
fell back to Spark and now we fail the query?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to