pepijnve commented on PR #23522: URL: https://github.com/apache/datafusion/pull/23522#issuecomment-4982998917
BTW, I had based myself a bit on this comment in `RepartitionExecState` ``` // Create spill channels based on mode: // - preserve_order: one spill channel per (input, output) pair for proper FIFO ordering // - non-preserve-order: one shared spill channel per output partition since all inputs // share the same receiver ``` When `preserve_order` is requested, you get an `SPSC` channel per input and FIFO is guaranteed. When it is not requested, you get a single `MPSC` channel for all inputs and order is undefined. That aspect hasn't changed. What I've tried to clarify in the documentation is that the FIFO guarantee is only in the `SPSC` case, not the `MPSC` one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
