adriangb commented on PR #23522: URL: https://github.com/apache/datafusion/pull/23522#issuecomment-4982372910
I'm worried about dropping the FIFO semantics (even if they were broken). Consider a plan like `Projection(inner=Repartition(inner=Sort, preserve_order=true)))`: if `RepartitionExec` does *not* actually preserve order under spilling then the sort order will be lost and the results will be wrong. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
